Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Update vcpkg to fix build error on macOS #1580

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ChaseKnowlden
Copy link
Contributor

Fixes missing symbol on macOS Silicon and now it builds successfully.

Fixes #1526

@ChaseKnowlden ChaseKnowlden changed the title Meta: Update vcpkg to fix build error Meta: Update vcpkg to fix build error on macOS Sep 30, 2024
@yikerman
Copy link

yikerman commented Oct 1, 2024

Can confirm this solves my issue. :shipit:

@LucasChollet
Copy link
Contributor

LucasChollet commented Oct 1, 2024

If non-release revisions of vcpkg aren't stable we should probably only use released versions. (If I checked correctly you aren't updating to the latest release: 2024.09.23.) (Also disregard my comment if the fix isn't available in that release, but in this case we might want to ask them to backport it 🤔)

@BertalanD
Copy link
Member

but in this case we might want to ask them to backport it 🤔

To an existing release? Releases/git tags are immutable, and I doubt they'd create a point release just for our tiny problem.

Looks like we are already using an arbitrary commit, so this looks okay.

@LucasChollet
Copy link
Contributor

The commit message made me think it was related to vcpkg itself, not a library. I agree that it actually doesn't make sense to backport the fix we want.

Looks like we are already using an arbitrary commit, so this looks okay.

The last time we updated was the first time we used an arbitrary commit. My point was that if we see problems with vcpkg itself when living closer to head, we should probably not do that. But anyway, this isn't the case, so yeah, it looks okay. And sorry for the noise.

@ADKaster ADKaster merged commit f4648f7 into LadybirdBrowser:master Oct 4, 2024
6 checks passed
@ChaseKnowlden ChaseKnowlden deleted the update-vcpkg branch October 4, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed on macOS Silicon: ___arm_tpidr2_save symbol not found from libyuv
5 participants